react-flux 1.2.1 → 1.2.2
raw patch · 7 files changed
+24/−11 lines, 7 filesPVP ok
version bump matches the API change (PVP)
API changes (from Hackage documentation)
Files
- ChangeLog.md +5/−0
- react-flux.cabal +1/−1
- src/React/Flux/Views.hs +6/−6
- test/spec/TestClientSpec.hs +4/−1
- test/spec/TodoSpec.hs +4/−1
- test/spec/react-flux-spec.cabal +1/−1
- test/spec/stack.yaml +3/−1
ChangeLog.md view
@@ -1,3 +1,8 @@+# 1.2.2++* Update the test suite to use hspec-webdriver-1.2. There was no change to any code+ besides the test suite.+ # 1.2.1 * A few fixes to get the haddock documentation (hopefully) working on hackage, no functional
react-flux.cabal view
@@ -1,5 +1,5 @@ name: react-flux-version: 1.2.1+version: 1.2.2 synopsis: A binding to React based on the Flux application architecture for GHCJS category: Web homepage: https://bitbucket.org/wuzzeb/react-flux
src/React/Flux/Views.hs view
@@ -37,6 +37,12 @@ -- This module supports 3 kinds of views. All of the views provided by this module are pure, in the -- sense that the rendering function and event handlers cannot perform any IO. All IO occurs inside -- the 'transform' function of a store.+--+-- Due to React limitations (see <https://github.com/facebook/react/issues/2127 issue2127>), React+-- views must have a single top-level element. If your haskell code returns multiple top-level+-- elements, react-flux will wrap them in a container @div@. You should not rely on this and instead+-- make sure each view returns only a single top-level element (such as @todoItem@ below returning only+-- a single @li@ element). newtype ReactView props = ReactView { reactView :: ReactViewRef props } ---------------------------------------------------------------------------------------------------@@ -108,12 +114,6 @@ -- Using a 'ReactView' provides more than just a Haskell function when used with a key property with -- 'viewWithSKey' and 'viewWithIKey'. The key property allows React to more easily reconcile the virtual DOM with the -- browser DOM.------ Due to React limitations (see <https://github.com/facebook/react/issues/2127 issue2127>), React--- views must have a single top-level element. If your haskell code returns multiple top-level--- elements, react-flux will wrap them in a container @div@. You should not rely on this and instead--- make sure each view returns only a single top-level element (such as @todoItem@ below returning only--- a single @li@ element). -- -- The following is two example views: @mainSection_@ is just a Haskell function and @todoItem@ -- is a React view. We use the convention that an underscore suffix signifies a combinator
test/spec/TestClientSpec.hs view
@@ -82,8 +82,11 @@ spec :: Spec spec = testClientSpec "test-client.html" +allBrowsers :: [Capabilities]+allBrowsers = [chromeCaps]+ testClientSpec :: String -> Spec-testClientSpec filename = session " for the test client" $ using Chrome $ do+testClientSpec filename = session " for the test client" $ using allBrowsers $ do it "opens the page" $ runWD $ do dir <- liftIO $ getCurrentDirectory openPage $ "file://" ++ dir ++ "/../client/" ++ filename
test/spec/TodoSpec.hs view
@@ -38,8 +38,11 @@ entries <- findElems $ ByCSS "ul#todo-list > li" return $ entries !! i +allBrowsers :: [Capabilities]+allBrowsers = [chromeCaps]+ spec :: Spec-spec = session " for todo example application" $ using Chrome $ do+spec = session " for todo example application" $ using allBrowsers $ do it "opens the page" $ runWD $ do dir <- liftIO $ getCurrentDirectory openPage $ "file://" ++ dir ++ "/../../example/todo/todo.html"
test/spec/react-flux-spec.cabal view
@@ -11,7 +11,7 @@ build-depends: base , hspec , webdriver- , hspec-webdriver+ , hspec-webdriver >= 1.2 , directory , process , transformers
test/spec/stack.yaml view
@@ -1,3 +1,5 @@-resolver: lts-6.1+resolver: nightly-2016-08-28 packages: - '.'+extra-deps:+- hspec-webdriver-1.2