hls-hlint-plugin 1.0.2.0 → 1.0.2.1
raw patch · 3 files changed
+7/−10 lines, 3 filesdep ~ghcide
Dependency ranges changed: ghcide
Files
- hls-hlint-plugin.cabal +2/−2
- src/Ide/Plugin/Hlint.hs +2/−2
- test/Main.hs +3/−6
hls-hlint-plugin.cabal view
@@ -1,6 +1,6 @@ cabal-version: 2.4 name: hls-hlint-plugin-version: 1.0.2.0+version: 1.0.2.1 synopsis: Hlint integration plugin with Haskell Language Server description: Please see the README on GitHub at <https://github.com/haskell/haskell-language-server#readme>@@ -55,7 +55,7 @@ , extra , filepath , ghc-exactprint >=0.6.3.4- , ghcide ^>=1.4 || ^>=1.5+ , ghcide ^>=1.5.0 , hashable , hlint , hls-plugin-api >=1.1 && <1.3
src/Ide/Plugin/Hlint.hs view
@@ -237,14 +237,14 @@ where moduleEx :: ParseFlags -> Action (Maybe (Either ParseError ModuleEx)) #ifndef HLINT_ON_GHC_LIB moduleEx _flags = do- mbpm <- getParsedModule nfp+ mbpm <- getParsedModuleWithComments nfp return $ createModule <$> mbpm where createModule pm = Right (createModuleEx anns modu) where anns = pm_annotations pm modu = pm_parsed_source pm #else moduleEx flags = do- mbpm <- getParsedModule nfp+ mbpm <- getParsedModuleWithComments nfp -- If ghc was not able to parse the module, we disable hlint diagnostics if isNothing mbpm then return Nothing
test/Main.hs view
@@ -131,8 +131,7 @@ doc <- openDoc "IgnoreAnn.hs" "haskell" expectNoMoreDiagnostics 3 doc "hlint" - , knownBrokenForHlintOnRawGhc "[#838] hlint plugin doesn't honour HLINT annotations" $- testCase "hlint diagnostics ignore hints honouring HLINT annotations" $ runHlintSession "" $ do+ , testCase "hlint diagnostics ignore hints honouring HLINT annotations" $ runHlintSession "" $ do doc <- openDoc "IgnoreAnnHlint.hs" "haskell" expectNoMoreDiagnostics 3 doc "hlint" @@ -158,8 +157,7 @@ liftIO $ not (hasApplyAll thirdLine) @? "Unexpected apply all code action" liftIO $ hasApplyAll multiLine @? "Missing apply all code action" - , knownBrokenForHlintOnRawGhc "[#2042] maybe hlint is ignoring pragmas" $- testCase "hlint should warn about unused extensions" $ runHlintSession "unusedext" $ do+ , testCase "hlint should warn about unused extensions" $ runHlintSession "unusedext" $ do doc <- openDoc "UnusedExtension.hs" "haskell" diags@(unusedExt:_) <- waitForDiagnosticsFromSource doc "hlint" @@ -174,8 +172,7 @@ waitForAllProgressDone -- hlint will report a parse error if PatternSynonyms is enabled expectNoMoreDiagnostics 3 doc "hlint"- , knownBrokenForHlintOnRawGhc "[#2280] maybe hlint is ignoring pragmas" $- testCase "hlint should not warn about redundant irrefutable pattern with LANGUAGE Strict" $ runHlintSession "" $ do+ , testCase "hlint should not warn about redundant irrefutable pattern with LANGUAGE Strict" $ runHlintSession "" $ do doc <- openDoc "StrictData.hs" "haskell" waitForAllProgressDone